Messages in this thread | | | Subject | Re: [PATCH 1/3] w35und: Move ETH_LENGTH_OF_ADDRESS to wbhal_s.h | From | Harvey Harrison <> | Date | Thu, 08 Jan 2009 02:13:30 -0800 |
| |
On Thu, 2009-01-08 at 11:56 +0200, Pekka Enberg wrote: > On Thu, 2009-01-08 at 01:46 -0800, Harvey Harrison wrote: > > On Thu, 2009-01-08 at 11:30 +0200, Pekka J Enberg wrote: > > > From: Pekka Enberg <penberg@cs.helsinki.fi> > > > > > > +#define ETH_LENGTH_OF_ADDRESS 6 > > > > Or just use ETH_ALEN like the rest of the kernel and drop this guy. > > Even better, thanks Harvey! Greg, please use this one instead. The rest > of the series is unaffected by the changes in this patch. > > >From c849ed5b5e68953a72f8dc43066513f118822f94 Mon Sep 17 00:00:00 2001 > From: Pekka Enberg <penberg@cs.helsinki.fi> > Date: Thu, 8 Jan 2009 11:10:06 +0200 > Subject: [PATCH] w35und: convert code to use ETH_ALEN > > As suggested by Harvey Harrison, convert driver to use ETH_ALEN and kill a > private macro from common.h that is used for the same thing.
Untested, but obviously ACK the approach :-)
Harvey
| |