lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] async: Don't call async_synchronize_full_special() while holding sb_lock
On Thu, 08 Jan 2009 14:51:52 -0800
Arjan van de Ven <arjan@linux.intel.com> wrote:

> Dave Chinner wrote:
> > On Thu, Jan 08, 2009 at 09:46:31AM -0600, Dave Kleikamp wrote:
> >> sync_filesystems() shouldn't be calling async_synchronize_full_special
> >> while holding a spinlock. The second while loop in that function is the
> >> right place for this anyway.
> >
> > Out of curiousity, what on earth does
> > async_synchronize_full_special() do and why does it need to be in
> > sync_filesystems()?
> >
> now that we have asynchronous operations, this function makes sure that all the functions
> that we started async before this point complete, so that what when you sync, you sync all in progress work.

So why is it special - wouldn't async_synchronize_all() be a bit (or
complete_all) be a bit more clear ?

Alan


\
 
 \ /
  Last update: 2009-01-09 01:35    [W:0.071 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site