lkml.org 
[lkml]   [2009]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
    From
    From: Bryan Wu <cooloney@kernel.org>
    Date: Thu, 8 Jan 2009 00:14:39 +0800

    > +#define VLAN_ETHER_TYPE 0x8100

    Please use ETH_P_8021Q from linux/if_ether.h instead of inventing
    your own definition.

    > + /* The legal length of the frame is increased to 1538 bytes */
    > + /*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/

    Please do not add code that is just going to be commented
    out and not used.

    Also, I disagree with the:

    +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)

    conditional. Probably this part of the chip should be programmed
    unconditionally.

    We can get VLAN packets received and sent, using AF_PACKET
    sockets, for example. The chip should still respect those
    even if VLAN proper is not being utilized.


    \
     
     \ /
      Last update: 2009-01-08 19:59    [W:3.593 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site