lkml.org 
[lkml]   [2009]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: mpparse.c fix style problems
On Sun, Jan 4, 2009 at 10:53 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> Similarly in arch/x86/include/asm/io_apic.h :
>> 1. struct mp_config_ioapic with mp_X fields (what name will be best ?)
>> 2. struct mp_config_intsrc with mp_X fields
>>
>> These are also used in arch/x86/kernel/mpparse.c
>>
>> Please let me know should I fix mp_X things first or should I proceed
>> further in mpparse.c as per your suggestions.
>
> i think those should be standardized to mpc_X too, and the fields should
> lose their mp_ prefix.
>

Earlier we was having 2 sets :-

struct mpc_config_ioapic (mpspec) and mp_config_ioapic (ioapic)
struct mpc_config_intsrc (mpspec) and mp_config_intsrc (ioapic)

We moved struct mpc_config_X to struct mpc_X

I want to know what should be name for mp_config_ioapic. Is struct
mp_ioapic is OK ?

JSR


\
 
 \ /
  Last update: 2009-01-04 18:37    [W:0.094 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site