lkml.org 
[lkml]   [2009]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2 of 7] x86/pvops: add a paravirt_ident functions to allow special patching
Rusty Russell wrote:
> I think I prefer:
>
> /* make_pte etc and pgd_val etc are identity functions. */
> #define paravirt_native_page_op \
> (sizeof(pte_t) == sizeof(u64) ? paravirt_ident_64 : paravirt_ident_32)
>
> Then use that everywhere rather than these defines?
>

Hm, also I don't think that will work because paravirt_ident_32|64
return different types. The compiler might promote paravirt_ident_32 to
returning a 64-bit number, which would be a bit disastrous.

J


\
 
 \ /
  Last update: 2009-01-29 11:49    [W:0.642 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site