lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH revised] firewire: sbp2: add workarounds for 2nd and 3rd generation iPods
Date
On Wednesday 28 January 2009 18:11:59 Stefan Richter wrote:
> According to https://bugs.launchpad.net/bugs/294391
> - 3rd generation iPods need the "fix capacity" workaround after all
> (apparently they crash after the last sector was accessed),
> - 2nd generation iPods need the "128 kB maximum request size"
> workaround.
>
> Alas both iPod generations feature the same model ID in the config ROM,
> hence we can only define a shared quirks list entry for them. Luckily
> the fix capacity workaround did not show a negative effect in Jarod's
> tests with 2nd gen. iPod.
>
> A side note: Apple computers in target mode (or at least an x86 Mac
> mini) don't have firmware_version and model_id, hence none of the iPod
> quirks list entries is active for them.
>
> Tested-by: Jarod Wilson <jarod@redhat.com>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Looks golden to me, and I've wedged this into the latest Fedora rawhide
kernels. Go 'head and add this too:

Acked-by: Jarod Wilson <jarod@redhat.com>

Thanks much!

--
Jarod Wilson
jarod@redhat.com



\
 
 \ /
  Last update: 2009-01-29 04:49    [W:0.042 / U:2.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site