lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] work_on_cpu: Use our own workqueue.
Date
On Thursday 29 January 2009 06:14:40 Andrew Morton wrote:
> It's vulnerable to the same deadlock, I think? Suppose we have:
...
> - A calls work_on_cpu() and takes woc_mutex.
>
> - Before function_which_takes_L() has started to execute, task B takes L
> then calls work_on_cpu() and task B blocks on woc_mutex.
>
> - Now function_which_takes_L() runs, and blocks on L

Agreed, but now it's a fairly simple case. Both sides have to take lock L, and both have to call work_on_cpu.

Workqueues are more generic and widespread, and an amazing amount of stuff gets called from them. That's why I felt uncomfortable with removing the one known problematic caller.

Thanks,
Rusty.


\
 
 \ /
  Last update: 2009-01-29 02:47    [W:0.085 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site