lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] migration: migrate_vmas should check "vma"
On Wed, 28 Jan 2009 17:55:12 +0100, Johannes Weiner <hannes@cmpxchg.org> wrote:
> On Wed, Jan 28, 2009 at 11:42:36AM -0500, Christoph Lameter wrote:
> > On Wed, 28 Jan 2009, Daisuke Nishimura wrote:
> >
> > > migrate_vmas() should check "vma" not "vma->vm_next" for for-loop condition.
> >
> > The loop condition is checked before vma = vma->vm_next. So the last
> > iteration of the loop will now be run with vma = NULL?
>
> No, the condition is always checked before the body is executed. The
> assignment to vma->vm_next happens at the end of every body.
>
So, I think in current code the loop body is not executed
about the last vma in the list.


Thanks,
Daisuke Nishimura.

> Try this:
>
> int a = 2;
>
> for (puts("init"); puts("cond"), a; puts("next"))
> a--;
>
> Hannes


\
 
 \ /
  Last update: 2009-01-29 02:25    [W:0.031 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site