Messages in this thread | | | Subject | Re: [PATCH] firmware: speed up request_firmware() | From | Matt Mackall <> | Date | Wed, 28 Jan 2009 12:35:22 -0600 |
| |
On Wed, 2009-01-28 at 18:11 +0000, Alan Cox wrote: > > Without this patch, loading a 12MB firmware image (FPGA bitfiles) called > > vmalloc() approximately 3000 times. With the patch, vmalloc() is only > > called 13 times, however, some memory is wasted until firmware_release() is > > called. Usually, this happens very quickly, so it shouldn't be a problem. > > Particularly on 32bit x86 vmalloc memory space is very precious so while > the current buffer size default may be too small doubling repeatedly is > not a good model IMHO.
How about a small exponent like 1.1?
-- http://selenic.com : development and support for Mercurial and Linux
| |