Messages in this thread | | | Date | Wed, 28 Jan 2009 14:49:55 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 05/10] omap mailbox: fix empty struct device for omap1 |
| |
On Fri, Jan 16, 2009 at 10:27:27AM +0200, Hiroshi DOYU wrote: > @@ -17,6 +17,8 @@ > #include <mach/mailbox.h> > #include <mach/irqs.h> > > +#define DRV_NAME "omap1-mailbox"
I don't see any need for this define - it just adds an additional level of indirection when trying to find out the name of the driver. It's only used in two places as is, so it's value is rather limited:
> @@ -184,9 +184,9 @@ static int omap1_mbox_remove(struct platform_device *pdev) > > static struct platform_driver omap1_mbox_driver = { > .probe = omap1_mbox_probe, > - .remove = omap1_mbox_remove, > + .remove = __devexit_p(omap1_mbox_remove), > .driver = { > - .name = "mailbox", > + .name = DRV_NAME, > }, > }; > > @@ -203,4 +203,7 @@ static void __exit omap1_mbox_exit(void) > module_init(omap1_mbox_init); > module_exit(omap1_mbox_exit); > > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions"); > +MODULE_AUTHOR("Hiroshi DOYU" <Hiroshi.DOYU@nokia.com>); > +MODULE_ALIAS("platform:"DRV_NAME);
| |