Messages in this thread | | | Date | Wed, 28 Jan 2009 23:17:41 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: Force panic on continuous CPRNG test failure when in FIPS mode |
| |
On Wed, Jan 28, 2009 at 07:15:11AM -0500, Neil Horman wrote: > On Wed, Jan 28, 2009 at 03:18:28PM +1100, Herbert Xu wrote: > > > > I'm OK with this change but I'd like it to look like: > > > > if (fips_enabled) { > > panic(...) > > } > > > > blah blah blah > > > > This way the FIPS crap doesn't get in the way of everyday use. > > > > Thanks, > > > Sure, new patch, extra commentary removed. Also brought the panic/printk text > into agreement.
Hmm no I wasn't referring to the comment, but rather that you should just move the stuff in the else branch into the main code path since the panic makes the else redundant.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |