Messages in this thread Patch in this message | | | Date | Wed, 28 Jan 2009 20:56:22 +0900 | From | Kenji Kaneshige <> | Subject | [PATCH 5/8] PCI: fix wrong assumption in pci_find_upstream_pcie_bridge |
| |
Current pci_find_upstream_pcie_bridge() has a wrong assumption that pci_bus->self is NULL on the root pci bus. But it might not true on some platforms. Because of this wrong assumption, current pci_find_upstream_pcie_bridge() might cause endless loop. We must check pci_bus->parent instead.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
--- drivers/pci/search.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.29-rc2/drivers/pci/search.c =================================================================== --- linux-2.6.29-rc2.orig/drivers/pci/search.c +++ linux-2.6.29-rc2/drivers/pci/search.c @@ -29,7 +29,7 @@ pci_find_upstream_pcie_bridge(struct pci if (pdev->is_pcie) return NULL; while (1) { - if (!pdev->bus->self) + if (!pdev->bus->parent) break; pdev = pdev->bus->self; /* a p2p bridge */
| |