Messages in this thread | | | Date | Wed, 28 Jan 2009 13:37:58 +0200 (EET) | Subject | Re: [PATCH 3/6] omap iommu: omap3 iommu device registration | From | Hiroshi DOYU <> |
| |
From: ext Russell King - ARM Linux <linux@arm.linux.org.uk> Subject: Re: [PATCH 3/6] omap iommu: omap3 iommu device registration Date: Wed, 28 Jan 2009 11:41:57 +0100
> On Tue, Jan 27, 2009 at 11:29:35PM +0200, Hiroshi DOYU wrote: > > I attached the update one. > > Thanks. I want to hold off on taking these just a little bit longer.
OK. agreed.
> > +static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = { > > + { > > + .name = "isp", > > + .nr_tlb_entries = 8, > > + .clk_name = "cam_ick", > > + }, > > + { > > + .name = "iva2", > > + .nr_tlb_entries = 32, > > + .clk_name = "iva2_ck", > > With the omap clk implementation in a state of flux, hopefully moving > towards something which better reflects the intentions of the clk API, > passing clk names around becomes entirely wasteful and unnecessary. > > That's not to say that what you currently have won't work with the patches > as they currently stand - it will work as is. I'd just rather avoid > having to have a separate patch to convert this code as well.
OK. I'll update later, then.
| |