lkml.org 
[lkml]   [2009]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] export get_task_comm()
Date
> > > It's worth a checkpatch rule, I guess: "direct access to
> > > task_struct.comm is racy - use get_task_comm()".
> >
> > And majority of usages is some debugging printk where nobody cares if ->comm
> > corrupted.
> >
> > Changelog says is useful for debugging. That's right, tsk->comm is useful
> > for debugging, not allocating temporary buffer + get_task_comm().
> >
> > Some ->comm usages are for kernel threads which never change it, for starters.
> >
> > current->comm is always safe, because, current is not executing prctl(2)!
>
> That's a good point.
>
> > I'd say nothing should be done and, heavens forbid, adding this to checkpatch.pl.
>
> hm, yeah, OK, I'll drop it.

Oh, I have to agree Alexey because he is always right ;)






\
 
 \ /
  Last update: 2009-01-27 11:19    [W:0.076 / U:1.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site