Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] export get_task_comm() | Date | Tue, 27 Jan 2009 19:15:52 +0900 (JST) |
| |
> > > It's worth a checkpatch rule, I guess: "direct access to > > > task_struct.comm is racy - use get_task_comm()". > > > > And majority of usages is some debugging printk where nobody cares if ->comm > > corrupted. > > > > Changelog says is useful for debugging. That's right, tsk->comm is useful > > for debugging, not allocating temporary buffer + get_task_comm(). > > > > Some ->comm usages are for kernel threads which never change it, for starters. > > > > current->comm is always safe, because, current is not executing prctl(2)! > > That's a good point. > > > I'd say nothing should be done and, heavens forbid, adding this to checkpatch.pl. > > hm, yeah, OK, I'll drop it.
Oh, I have to agree Alexey because he is always right ;)
| |