Messages in this thread | | | Date | Tue, 27 Jan 2009 01:09:43 -0500 | From | Kyle McMartin <> | Subject | Re: [PATCH] make checkpatch warn about access to current->comm |
| |
On Tue, Jan 27, 2009 at 02:58:51PM +0900, KOSAKI Motohiro wrote: > > On Tue, Jan 27, 2009 at 02:50:18PM +0900, KOSAKI Motohiro wrote: > > > I think "char tcomm[sizeof(current->comm)];" is valid code. > > > if checkpatch.pl don't warn "sizeof(current->comm)", I'm glad. > > > > Awfully interesting way of writing TASK_COMM_LEN :) > > I don't think so awfully. > I think "sizeof(array_val)" is typical code in kernel. > > I agree that we can rewrite s/tcomm[sizeof(current->comm)]/char tcomm[TASK_COMM_LEN]/. > but it's annoyed. >
If current->comm was changed to be kmalloc'd this would need to be changed anyway, so why not just do it now?
regards, Kyle
| |