Messages in this thread | | | Subject | Re: [RFC PATCH 01/19] lockdep: annotate reclaim context (__GFP_NOFS) | From | Peter Zijlstra <> | Date | Fri, 23 Jan 2009 09:00:57 +0100 |
| |
On Fri, 2009-01-23 at 08:33 +0100, Nick Piggin wrote: > On Thu, Jan 22, 2009 at 09:29:47PM +0100, Peter Zijlstra wrote: > > On Thu, 2009-01-22 at 20:40 +0100, Peter Zijlstra wrote: > > > > + return; > > > > + if (DEBUG_LOCKS_WARN_ON(irqs_disabled())) > > > > + return; > > > > + > > > > + mark_held_locks(curr, RECLAIM_FS); > > > > +} > > > > > > Not quite seeing how this happens though... > > > > > > [ 6.998258] WARNING: at /usr/src/linux-2.6/kernel/lockdep.c:2266 > > > lockdep_trace_alloc+0x58/0x69() > > > > Doh, its getting there without __GFP_WAIT... > > Ah, sorry. Thanks for debugging. Should just be a matter of sticking > a check for GFP_WAIT in there somewhere?
Yeah, I'll stick a check in there, that ought to suffice.
> Thanks for pulling this in BTW (hopefully you don't see any more issues). > Your subsequent improvements all seem pretty nice to me too (although I > don't know the lockdep code well, but I didn't see any obviuos problems).
Thanks, I'll test it some today, and hopefully stuff will just work ;-)
| |