Messages in this thread | | | Date | Thu, 15 Jan 2009 20:34:28 -0800 | Subject | Re: [PATCH] use hierarchy mutex in creation failure path | From | Paul Menage <> |
| |
On Thu, Jan 15, 2009 at 7:17 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Now, cgrp->sibling is handled under hierarchy mutex. > error route should do so, too. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by Paul Menage <menage@google.com>
Good catch, thanks.
Paul
> > --- > kernel/cgroup.c | 2 ++ > 1 file changed, 2 insertions(+) > > Index: mmotm-2.6.29-Jan14/kernel/cgroup.c > =================================================================== > --- mmotm-2.6.29-Jan14.orig/kernel/cgroup.c > +++ mmotm-2.6.29-Jan14/kernel/cgroup.c > @@ -2434,7 +2434,9 @@ static long cgroup_create(struct cgroup > > err_remove: > > + cgroup_lock_hierarchy(root); > list_del(&cgrp->sibling); > + cgroup_unlock_hierarchy(root); > root->number_of_cgroups--; > > err_destroy: > >
| |