Messages in this thread | | | Date | Thu, 15 Jan 2009 15:19:14 -0800 (PST) | Subject | Re: [PATCH] tcp: splice as many packets as possible at once | From | David Miller <> |
| |
From: Willy Tarreau <w@1wt.eu> Date: Fri, 16 Jan 2009 00:03:31 +0100
> please don't merge it as-is. I've just tried it and got an OOM > in __alloc_pages_internal after a few seconds of data transfer. > > I'm leaving the patch below for comments, maybe someone will spot > something ? Don't we need at least one kfree() somewhere to match > alloc_pages() ?
What is needed is a put_page().
But that should be happening as a result of the splice callback.
| |