lkml.org 
[lkml]   [2009]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] block: export SSD/non-rotational queue flag through sysfs
    From
    On Thu, Jan 15, 2009 at 11:00 AM, James Bottomley
    <James.Bottomley@hansenpartnership.com> wrote:
    ...
    >> Code can test for zero/nonzero or (preferably) more fine grained.
    >> e.g. "avgreadcost > 1ms" or "avgwritecost". I'm hoping this test
    >> can be abstracted into a macro.
    >
    > Um these really have to be things we can get out of the device at boot
    > time without effort (as in part of the data the device can give in a
    > single command). I'll be shot for increasing boot time so we can work
    > out these parameters ...

    No. The whole point is we should not care what it is at boot time.
    It should be based on recent history of what is going on.
    At boot time we read the partition table and we superblocks to mount
    file systems.
    That's fine to start with. So I don't see any need to add some synthetic test
    to establish initial values.

    The rest of the code should work regardless of what the values start out to be.
    This is true for the previous proposed patch too when user space has
    to decide what the right policy is.

    >> I'm hoping longterm, the values could be "self tuning" but don't know
    >> how that might work - e.g. 1 minute avg? 10 minute avg? Cost
    >> of collecting/maintaining the stats? Feels like a CONFIG option.
    >
    > CONFIG_SLOW_YOUR_BOOT?

    maybe CONFIG_AUTOTUNE_RWCOST.

    thanks,
    grant


    \
     
     \ /
      Last update: 2009-01-16 00:01    [W:4.396 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site