| From | Janne Grunau <> | Subject | Re: [PATCH 0/18] linux infrared remote control drivers | Date | Tue, 9 Sep 2008 10:32:50 +0200 |
| |
On Tuesday 09 September 2008 09:06:03 Alexey Dobriyan wrote: > > All version.h and autoconf.h inclusions aren't needed.
I'll remove them.
> #ifdef MODULE is gross and very old. Don't need that. Just use > > static int __init x_init(void) > { > ... > } > > static void __exit x_exit(void) > { > ... > } > module_init(x_init); > module_exit(x_exit); > MODULE_LICENSE > ... > > It will work correctly in modular and built-in case.
Will do so.
> Static number of devices is simple but how about adding them > dynamically.
Will have a look
Janne
|