Messages in this thread | | | Date | Fri, 05 Sep 2008 13:06:06 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [BUG] x86 kenel won't boot under Virtual PC |
| |
Ingo Molnar wrote: > * Linus Torvalds <torvalds@linux-foundation.org> wrote: > >> - Move the optimized nop definitions (K7_NOPx etc) to the only place that >> cares - asm/x86/kernel/alternative.c. When we do things _dynamically_, >> it can actually make sense to pick a nop more precisely, but for this >> whole static thing it's just a pain. >> >> IOW, if it actually _worked_ reasonably, I wouldn't care. But clearly >> it doesn't. And once it's not working reasonably, it should be fixed. > > yes - we had 3-4 tries already and while it looked worthwile initially > it's clearly not showing signs of getting more robust and whatever > benefits there might be slightly better NOPs is dwarved by all these > robustness problems. Peter?
There is already a fix for this based on a first-principles test in tip.
-hpa
| |