lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] x86/iommu: change Calgary to use dma_ops register interface

* Muli Ben-Yehuda <muli@il.ibm.com> wrote:

> > > +static int calgary_device_supported(struct device *dev)
> > > +{
> > > + return translation_enabled(find_iommu_table(dev));
> > > +}
>
> Sure, but I prefer the explicit form since it lends itself to easier
> debugging (oops line numbers, adding printks, etc.).

we never do that for simple stuff like this. The kernel would be twice
as large if we did. An oops is easy enough to decode and an oops does
not come with a line number.

Ingo


\
 
 \ /
  Last update: 2008-09-30 17:43    [W:0.059 / U:2.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site