Messages in this thread | | | Date | Tue, 30 Sep 2008 17:38:15 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 6/9] x86/iommu: change Calgary to use dma_ops register interface |
| |
* Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> > > +static int calgary_device_supported(struct device *dev) > > > +{ > > > + return translation_enabled(find_iommu_table(dev)); > > > +} > > Sure, but I prefer the explicit form since it lends itself to easier > debugging (oops line numbers, adding printks, etc.).
we never do that for simple stuff like this. The kernel would be twice as large if we did. An oops is easy enough to decode and an oops does not come with a line number.
Ingo
| |