lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to the new type of print_line

* Frédéric Weisbecker <fweisbec@gmail.com> wrote:

> 2008/9/30 Steven Rostedt <rostedt@goodmis.org>:
> >
> > OK, I'll nuke the ring_buffer_lock :-/
> >
> > The trace_pipe calls that and then calls print_trace_line which will
> > eventually lock the buffer again. This is a bug on my part. I'll fix that
> > today.
> >
> > Thanks,
>
> Strange, I can't see any case where print_trace_line could call the
> ring_buffer_lock.
> Hmm, I will see in your patch.
>
> Ingo, I just saw one damage from the merging, trace_empty() returns
> TRACE_TYPE_HANDLED. The type is wrong, it should return 1. It's not
> urgent since the value is the same. Should I send a patch for such a
> small error?

yes, please do. One too many patch is far better than one too few ;-)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-09-30 17:43    [W:0.055 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site