Messages in this thread | | | Date | Tue, 30 Sep 2008 08:23:34 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] x86: do not allow to optimize flag_is_changeable_p() |
| |
krzysztof.h1@poczta.fm wrote: > If your assembler instructions access memory in an unpredictable > fashion, add `memory' to the list of clobbered registers. This will > cause GCC to not keep memory values cached in registers across the > assembler instruction and not optimize stores or loads to that memory. > You will also want to add the `volatile' keyword if the memory affected > is not listed in the inputs or outputs of the `asm', as the `memory' > clobber does not count as a side-effect of the `asm'. If you know how > large the accessed memory is, you can add it as input or output but if > this is not known, you should add `memory'. >
Yes, you're right. The pertinent part of the manual is:
The `volatile' keyword indicates that the instruction has important side-effects. GCC will not delete a volatile `asm' if it is reachable. (The instruction can still be deleted if GCC can prove that control-flow will never reach the location of the instruction.) Note that even a volatile `asm' instruction can be moved relative to other code, including across jump instructions.
I normally do my "asm volatile" rant when people try to use it to enforce ordering, but in this case we just want gcc to not elide the second use.
So, yes, I think your patch is fine as-is, but it would be worth adding a comment on the asm (its not necessarily obvious that the cpuid-capability of a cpu can change).
J
| |