lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] x86: track memtype for RAM in page struct - v3

* Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> On Thursday 25 September 2008 01:53, Venki Pallipadi wrote:
>
> > /*
> > + * RED-PEN: TODO: Add PageReserved() check as well here,
> > + * once we add SetPageReserved() to all the drivers using
> > + * set_memory_* or set_pages_*.
> > + *
> > + * This will help prevent accidentally freeing pages
> > + * before setting the attribute back to WB.
> > + */
>
> I'd rather we didn't add any more uses of PageReserved without a
> really good reason.
>
> At this point in time (or at least last time I looked, a year or
> two ago), it isn't a whole lot of work to remove PG_reserved
> completely. If the waters get muddied up again, it could require
> another significant rework to remove it in future...

agreed.

Ingo


\
 
 \ /
  Last update: 2008-09-30 13:25    [W:0.082 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site