Messages in this thread | | | Date | Tue, 30 Sep 2008 11:45:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/6] Unified trace buffer |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> +void ring_buffer_lock(struct ring_buffer *buffer, unsigned long *flags) > +{ > + struct ring_buffer_per_cpu *cpu_buffer; > + int cpu; > + > + local_irq_save(*flags); > + > + for_each_buffer_cpu(buffer, cpu) { > + cpu_buffer = buffer->buffers[cpu]; > + spin_lock(&cpu_buffer->lock); > + } > +}
hm, that's rather unintelligent and needs to be fixed.
Ingo
| |