Messages in this thread | | | From | Elias Oltmanns <> | Subject | Re: [PATCH 3/4] ide: Implement disk shock protection support | Date | Wed, 03 Sep 2008 23:33:39 +0200 |
| |
Elias Oltmanns <eo@nebensachen.de> wrote: > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: [...] >> Also could you please move the new code to a separate file (i.e. >> ide-park.c) instead of stuffing it all in ide.c? > > This is probably a sensible idea especially since there may be more once > we go ahead with the in-kernel solution.
Sorry, I forgot to mention that I haven't a clue as to what headers to include explicitly in such a file. Actually, ide-park.c compiles on my system just with ide.h included. This would, however, be an unsuitably minimal approach, I fear. Some advice would be most welcome.
Regards,
Elias
| |