Messages in this thread | | | Date | Mon, 29 Sep 2008 18:45:19 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function |
| |
> > This is the same like pci_iomap(pdev, number, 0), no? > > Yeah... Looks like that function isn't that widely used though. Is the maxlen > param really needed? Looks like the drivers that use it often pass 0 or the
In some cases yes you do need the length.
> BAR length anyway, and Arjan converted existing drivers too, which is where > the real work is.
He could have converted them to the existing perfectly good API not invented another one. He still can - I'm sure its a perl one liner to redo them in terms of pci_iomap()
Alan
| |