Messages in this thread | | | Date | Sat, 27 Sep 2008 08:43:07 -0500 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH 4/6] file capabilities: clean up setcap code |
| |
Quoting Andrew G. Morgan (morgan@kernel.org): > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Serge, > > I have to say I'm a bit confused by this one. Specifically, the > cap_get_target_pid() change. In your 5/6 patch, you say this change > ("the previous patch") makes the kernel bigger? Is this because of the > cap_get_target_pid() changes? Since you are fighting to reduce space, if > it bloats the code does the cap_get_target_pid() part of the change make > sense?
Yes I think it does. Yes my goal was to decrease the kernel size, but having cleaner code - and getting rid of dead codepaths - is more important.
It may be hard to tell by looking at the patch, but I think the end-result is really far better.
thanks, -serge
| |