lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver available.
Hi,

A few comments

>
> Signed-off-by: Vishak G <vishak.g@samsung.com>
> Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>

Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

> ---
> diff -uprN a/drivers/mtd/onenand/onenand_base.c
> b/drivers/mtd/onenand/onenand_base.c
> --- a/drivers/mtd/onenand/onenand_base.c 2008-09-16
> 20:48:12.000000000 +0530
> +++ b/drivers/mtd/onenand/onenand_base.c 2008-09-24
> 17:51:34.000000000 +0530
> @@ -9,6 +9,10 @@
> * auto-placement support, read-while load support, various fixes
> * Copyright (C) Nokia Corporation, 2007
> *
> + * Vishak G <vishak.g@samsung.com>, Rohit Hagargundgi
> <h.rohit@samsung.com>
> + * Flex-OneNAND support
> + * Copyright (C) Samsung Electronics, 2008
> + *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> @@ -27,6 +31,37 @@
>
> #include <asm/io.h>
>
> +const static int boundary[] = {
> + FLEXONENAND_DIE0_BOUNDARY,
> + FLEXONENAND_DIE1_BOUNDARY,
> +};
> +
> +const static int lock[] = {
> + FLEXONENAND_DIE0_ISLOCKED,
> + FLEXONENAND_DIE1_ISLOCKED,
> +};
> +

static const as others.


> diff -uprN a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
> --- a/include/mtd/mtd-abi.h 2008-09-16 20:48:12.000000000 +0530
> +++ b/include/mtd/mtd-abi.h 2008-09-24 14:09:06.000000000 +0530
> @@ -102,7 +102,11 @@ struct nand_oobinfo {
> uint32_t useecc;
> uint32_t eccbytes;
> uint32_t oobfree[8][2];
> +#ifdef CONFIG_MTD_ONENAND
> + uint32_t eccpos[128];
> +#else
> uint32_t eccpos[32];
> +#endif
> };
>
> struct nand_oobfree {
> @@ -117,7 +121,11 @@ struct nand_oobfree {
> */
> struct nand_ecclayout {
> uint32_t eccbytes;
> +#ifdef CONFIG_MTD_ONENAND
> + uint32_t eccpos[128];
> +#else
> uint32_t eccpos[64];
> +#endif
> uint32_t oobavail;
> struct nand_oobfree oobfree[MTD_MAX_OOBFREE_ENTRIES];
> };
>
>

This patch is already included others. Please remove it at this patch.

Thank you,
Kyungmin Park


\
 
 \ /
  Last update: 2008-09-26 02:33    [W:0.059 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site