Messages in this thread | | | Date | Thu, 25 Sep 2008 22:45:24 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM |
| |
On Thu, 25 Sep 2008, Jesse Barnes wrote:
> Here's a patch that adds range checking to the sysfs mappings at least. > This patch should catch the case where X (or some other process) tries > to map beyond the specific BAR it's (supposedly) trying to access, > making things safer in general. FWIW both my F9 and development > versions of X start up fine with this patch applied.
Good. We will use this on affected machines after we start some real debugging of this.
> + /* > + * Make sure the range the user is trying to map falls within > + * the resource > + */ > + if (map_offset + map_len > pci_resource_len(pdev, i)) > + return -EINVAL; > +
At least for debugging purposes I'd propose to put a printk() there with process name, and the range it tries to map.
Thanks,
-- Jiri Kosina SUSE Labs
| |