lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/7] pci: using %pF in quirks.c
Date
On Thursday, September 25, 2008 7:56 am Bjorn Helgaas wrote:
> On Wednesday 24 September 2008 08:04:33 pm Yinghai Lu wrote:
> > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> > ---
> > drivers/pci/quirks.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 1f26712..addf2db 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -1689,8 +1689,7 @@ static void pci_do_fixups(struct pci_dev *dev,
> > struct pci_fixup *f, struct pci_f if ((f->vendor == dev->vendor ||
> > f->vendor == (u16) PCI_ANY_ID) && (f->device == dev->device || f->device
> > == (u16) PCI_ANY_ID)) { #ifdef DEBUG
> > - dev_dbg(&dev->dev, "calling ");
> > - print_fn_descriptor_symbol("%s\n", f->hook);
> > + dev_dbg(&dev->dev, "calling %pF\n", f->hook);
> > #endif
> > f->hook(dev);
> > }
>
> I posted a similar patch already:
> http://lkml.org/lkml/2008/8/22/178
>
> Maybe mine was too complicated because it touched more files at once.
> Regardless, we need to remove the #ifdef DEBUG because it's no longer
> necessary.

Yeah you sent it to Andrew and it touched several files; maybe I shouldn't
have ignored it. :)

Anyway I'll fix up the #ifdefs in my linux-next branch.

Thanks,
Jesse


\
 
 \ /
  Last update: 2008-09-25 18:23    [W:0.055 / U:2.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site