lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
Date
On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
> v2: fix hpet compiling
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> ---
> arch/x86/kernel/hpet.c | 3 +++
> arch/x86/kernel/io_apic.c | 7 +++++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index 422c577..686505a 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
> irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
> enable_irq(dev->irq);
>
> + printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> + dev->name, dev->irq, dev->irq);
> +

Why do we want to print the irq as hex? Do we do that anywhere else?
I think we should pick one format and stick with it, and I think
decimal is the logical choice because it's the most common.


\
 
 \ /
  Last update: 2008-09-25 17:31    [W:0.115 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site