Messages in this thread | | | Date | Thu, 25 Sep 2008 02:12:48 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v2] fbdev: ignore VESA modes if framebuffer does not support them |
| |
Michal Januszewski wrote: > Currently, it is possible to set a graphics VESA mode at boot time via > the vga= parameter even when no framebuffer driver supporting this is > configured. This could lead to the system booting with a black screen, > without a usable console. > diff --git a/include/linux/screen_info.h b/include/linux/screen_info.h > index 1ee2c05..20fdc2f 100644 > --- a/include/linux/screen_info.h > +++ b/include/linux/screen_info.h > @@ -76,6 +76,10 @@ extern struct screen_info screen_info; > #define ORIG_VIDEO_LINES (screen_info.orig_video_lines) > #define ORIG_VIDEO_ISVGA (screen_info.orig_video_isVGA) > #define ORIG_VIDEO_POINTS (screen_info.orig_video_points) > + > +#define FB_SUPPORTS_BOOT_VESA (defined(CONFIG_FB_VESA) || \ > + defined(CONFIG_FB_SIS) || defined(CONFIG_FB_IMAC) || \ > + defined(CONFIG_FB_INTEL)) > #endif /* __KERNEL__ */ > > #endif /* _SCREEN_INFO_H */
I'm *REALLY* skeptical to burying this in screen_info like this, it would probably be better to put it in Kconfig, or it is unlikely to get updated properly.
-hpa
| |