Messages in this thread | | | Date | Thu, 25 Sep 2008 10:34:16 +0800 | From | Yan Li <> | Subject | Re: [PATCH 1/2] VMware guest detection for x86 and x86-64 |
| |
On Wed, Sep 24, 2008 at 05:26:46PM -0700, H. Peter Anvin wrote: > Yan Li wrote: >> My motivation behind this patch is to serve the MTRR codes to fix a >> false warning, > > It's not a false warning. It's a true warning.
You can say that warning is justified because it's true that the MTRR's are all blank in VMware. But that warning is no good to VMware users since it's by-design all MTRR's are blank. For example, we've scripts watching the log for lines containing "warning" and "error" on all production servers. So this warning actually is "false" to VMware guest users. A KERN_INFO message should be enough here.
We already have a checking to suppress warning on KVM so I think we should also suppress the warning for VMware guest and Virtual PC.
-- Li, Yan
| |