Messages in this thread | | | Date | Wed, 24 Sep 2008 10:22:18 -0700 | From | Drew Moseley <> | Subject | Re: [PATCH] Create PNP device attributes via dev_attrs field of struct device |
| |
Kay Sievers wrote: > > Any reason not to assign it statically to pnp_bus_type at in > drivers/pnp/driver.c? > > Thanks, > Kay
Not really but since everything in the dev_attrs array is statically defined in interface.c it was simpler to implement it this way. To assign it in driver.c, the array can be made non-static and an extern added in driver.c, or the array definition can be moved to driver.c and all the set and show functions be made non-static. Is there a preference?
Thanks, Drew
| |