lkml.org 
[lkml]   [2008]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/3] Unified trace buffer


On Wed, 24 Sep 2008, Peter Zijlstra wrote:
>
> So when we reserve we get a pointer into page A, but our reserve length
> will run over into page B. A write() method will know how to check for
> this and break up the memcpy to copy up-to the end of A and continue
> into B.

I would suggest just not allowing page straddling.

Yeah, it would limit event size to less than a page, but seriously, do
people really want more than that? If you have huge events, I suspect it
would be a hell of a lot better to support some kind of indirection
scheme than to force the ring buffer to handle insane cases.

Most people will want the events to be as _small_ as humanly possible. The
normal event size should hopefully be in the 8-16 bytes, and I think the
RFC patch is already broken because it allocates that insane 64-bit event
counter for things. Who the hell wants a 64-bit event counter that much?
That's broken.

Linus


\
 
 \ /
  Last update: 2008-09-24 18:35    [W:0.126 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site