Messages in this thread | | | Date | Tue, 23 Sep 2008 13:03:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 4/4] x86: Add sysfs entries for UV |
| |
* Russ Anderson <rja@sgi.com> wrote:
> +struct kobject *sgi_uv_kobj;
should be static?
> +static int __init sgi_uv_sysfs_init(void) > +{ > + if (!sgi_uv_kobj) > + sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj); > + if (!sgi_uv_kobj) { > + printk(KERN_WARNING "kobject_create_and_add sgi_uv failed \n"); > + return -EINVAL; > + } > + > + sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr); > + sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);
missing checks for failure?
Ingo
| |