lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] x86: Add sysfs entries for UV

* Russ Anderson <rja@sgi.com> wrote:

> +struct kobject *sgi_uv_kobj;

should be static?

> +static int __init sgi_uv_sysfs_init(void)
> +{
> + if (!sgi_uv_kobj)
> + sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj);
> + if (!sgi_uv_kobj) {
> + printk(KERN_WARNING "kobject_create_and_add sgi_uv failed \n");
> + return -EINVAL;
> + }
> +
> + sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr);
> + sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);

missing checks for failure?

Ingo


\
 
 \ /
  Last update: 2008-09-23 13:05    [W:0.065 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site