lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH -tip 0/4] x86: signal handler improvement

* Ingo Molnar <mingo@elte.hu> wrote:

> could we perhaps first finish unifying them into signal.c, and then
> introduce __put_user_cerr() in signal_32/64.c?

i've got an API suggestion as well. Instead of:

- err |= __put_user(UC_FP_XSTATE, &frame->uc.uc_flags);
+ __put_user_cerr(UC_FP_XSTATE, &frame->uc.uc_flags, err);

could you instead please make it:

+ __put_user_cerr(UC_FP_XSTATE, &frame->uc.uc_flags, &err);

i.e. pass in 'err' as a reference. This makes it clear to the casual
reader, in a C calling convention sense, that there's a side-effect to
'err'. [ There should be no change to the resulting code as
__put_user_cerr() is a macro. ]

Ingo


\
 
 \ /
  Last update: 2008-09-23 10:59    [W:0.071 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site