lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)
On Wed, Sep 24, 2008 at 5:18 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> After sleeping all day, I changed my mind and decided to drop this.
> It seems no one like this.
>

I've not yet looked at the patch in detail, I just got back from a long travel.

> I'll add FLATMEM/DISCONTIGMEM/SPARSEMEM support directly.
> I already have wasted a month on this not-interesting work and want to fix
> this soon.
>

Let's look at the basic requirement, make memory resource controller
not suck with 32 bit systems. I have been thinking of about removing
page_cgroup from struct page only for 32 bit systems (use radix tree),
32 bit systems can have a maximum of 64GB if PAE is enabled, I suspect
radix tree should work there and let the 64 bit systems work as is. If
performance is an issue, I would recommend the 32 bit folks upgrade to
64 bit :) Can we build consensus around this approach?

> I'm glad if people help me to test FLATMEM/DISCONTIGMEM/SPARSEMEM because
> there are various kinds of memory map. I have only x86-64 box.

I can help test your patches on powerpc 64 bit and find a 32 bit
system to test it as well. What do you think about the points above?

Balbir


\
 
 \ /
  Last update: 2008-09-24 04:13    [W:0.106 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site