lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip/master] x86: io-apic - interrupt remapping fix
On Tue, Sep 23, 2008 at 12:00:02PM -0700, Cyrill Gorcunov wrote:
> ---
> From: Cyrill Gorcunov <gorcunov@gmail.com>
>
> Clean up obscure for() cycle with straight while() form
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> CC: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> Index: linux-2.6.git/arch/x86/kernel/io_apic.c
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/io_apic.c 2008-09-22 17:42:33.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/io_apic.c 2008-09-23 22:45:58.000000000 +0400
> @@ -830,9 +830,8 @@ int save_mask_IO_APIC_setup(void)
> return 0;
>
> nomem:
> - for (; apic > 0; apic--)
> - kfree(early_ioapic_entries[apic]);
> - kfree(early_ioapic_entries[apic]);
> + while (apic >= 0)
> + kfree(early_ioapic_entries[apic--]);
> memset(early_ioapic_entries, 0,
> ARRAY_SIZE(early_ioapic_entries));
>

looks better. thanks.


\
 
 \ /
  Last update: 2008-09-23 21:21    [W:0.057 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site