Messages in this thread | | | Date | Mon, 22 Sep 2008 15:40:25 -0600 | From | Alex Chiang <> | Subject | Re: [PATCH v2 02/13] PCI: prevent duplicate slot names |
| |
* Rolf Eike Beer <eike-kernel@sf-tec.de>: > > + > > + /* > > + * We hit this the first time through, which gives us > > + * space for terminating NULL, and then every power of 10 > > + * afterwards, which gives us space to add another digit > > + * to "name-XX..." > > + */ > > + if (dup % width == 0) { > > + len++; > > + width *= 10; > > + } > > + > > + new_name = krealloc(new_name, len, GFP_KERNEL); > > + if (!new_name) > > + goto out; > > If krealloc() fails you will leak the old new_name here.
Thanks for catching this. I already responded to Willy that I'm changing it to:
kfree(new_name); new_name = kmalloc(len, GFP_KERNEL);
That will prevent any leaks.
Thanks for the review.
/ac
| |