lkml.org 
[lkml]   [2008]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: do_generic_file_read() never gets a NULL 'filp' argument
On Mon, 22 Sep 2008 04:39:46 -0400 Christoph Hellwig <hch@infradead.org> wrote:

> On Mon, Sep 22, 2008 at 01:33:38AM -0700, Andrew Morton wrote:
> > On Mon, 22 Sep 2008 11:46:10 +0530 Krishna Kumar <krkumar2@in.ibm.com> wrote:
> >
> > > From: Krishna Kumar <krkumar2@in.ibm.com>
> > >
> > > The 'filp' argument to do_generic_file_read() is never NULL.
> > >
> >
> > How did you verify this?
> >
> > NFS used to like passing NULL file*'s into VFS functions. I don't
> > recall whether it affected do_generic_file_read().
>
> The only thing nfsd passed a NULL file pointer in is ->fsync on
> directories.

NFS, not NFSD. It was page_cache_read(), iirc.



\
 
 \ /
  Last update: 2008-09-22 19:41    [W:0.048 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site