Messages in this thread | | | Date | Sat, 20 Sep 2008 06:56:52 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCH] max3100 driver |
| |
\> > + int rx_enabled:1; /* if we should rx chars */ > > + > > + int irq; /* irq assigned to the max3100 */ > > + > > + int minor; /* minor number */ > > + int crystal:1; /* 1 if 3.6864Mhz crystal 0 > > for 1.8432 */ > > + int loopback:1; /* 1 if we are in loopback > > mode */ > > + int only_edge_irq:1; /* 1 if we have only edge irqs > > (like PXA) */ > > Lots of dittoes. > > These bitfields perhaps could be reordered to save a bit of space, but > that depends on the implicit locking rules for them. >
I do have a question though: what does a signed bitfield of 1 mean? I mean.. the variables are "int", so signed.... where will the compiler store the sign bit???
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |