lkml.org 
[lkml]   [2008]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] max3100 driver
\> > +	int rx_enabled:1;	/* if we should rx chars */
> > +
> > + int irq; /* irq assigned to the max3100 */
> > +
> > + int minor; /* minor number */
> > + int crystal:1; /* 1 if 3.6864Mhz crystal 0
> > for 1.8432 */
> > + int loopback:1; /* 1 if we are in loopback
> > mode */
> > + int only_edge_irq:1; /* 1 if we have only edge irqs
> > (like PXA) */
>
> Lots of dittoes.
>
> These bitfields perhaps could be reordered to save a bit of space, but
> that depends on the implicit locking rules for them.
>

I do have a question though: what does a signed bitfield of 1 mean?
I mean.. the variables are "int", so signed.... where will the compiler
store the sign bit???


--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-09-20 15:59    [W:0.085 / U:24.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site