Messages in this thread | | | Date | Fri, 19 Sep 2008 21:48:52 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/4 v2] libata: Implement disk shock protection support |
| |
Elias Oltmanns wrote: > Tejun Heo <htejun@gmail.com> wrote: >> Elias Oltmanns wrote: > Will do. By the way, it's just occurred to me that we really need to > call complete_all() in ata_scsi_park_store(). So, thanks for making me > think it all through once more.
Hmmm... just replied to the updated patch. complete_all() will potentially overflow the done counter (which BTW is interface problem in completion) why is it necessary? (probably best to continue on the other thread).
Thanks.
-- tejun
| |