Messages in this thread | | | Date | Sat, 20 Sep 2008 03:35:45 -0700 (PDT) | Subject | Re: [PATCH 2/2]: softirq: Add support for triggering softirq work on softirqs. | From | David Miller <> |
| |
From: Andrew Morton <akpm@linux-foundation.org> Date: Sat, 20 Sep 2008 00:46:08 -0700
> Seems from the above `>> 16' you're stuffing the softirq ID into the > upper 16 bits of call_single_data.flags. Is it needed? Another u32 > can be added to call_single_data for free on 64-bit, or it could be > split into two u16's.
call_single_data is already too large, simply adding it to struct sk_buff had negative performance impacts that are forcing me to trim the size of the existing structure a bit.
I think just documenting the usage of the bits is better, and I'll do that in my next rev.
| |