lkml.org 
[lkml]   [2008]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dmatest: properly handle duplicate DMA channels
On Sat, 20 Sep 2008 14:40:40 -0700 "Dan Williams" <dan.j.williams@intel.com> wrote:

> When I fix this up is there a
> canonical location to document a callback interface rather than at the
> callback's typedef?

Personally I like to see at at the definition site, so that's within
the struct which contains the function pointer. eg:

struct address_space_operations {
int (*writepage)(struct page *page, struct writeback_control *wbc);
int (*readpage)(struct file *, struct page *);
void (*sync_page)(struct page *);

/* Write back some dirty pages from this mapping. */
int (*writepages)(struct address_space *, struct writeback_control *);

/* Set a page dirty. Return true if this dirtied it */
int (*set_page_dirty)(struct page *page);

(sadly incomplete, but we tried)


\
 
 \ /
  Last update: 2008-09-21 00:23    [W:2.204 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site