lkml.org 
[lkml]   [2008]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: c1e_idle: don't mark TSC unstable if CPU has invariant TSC

* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> Currently the kernel assumes TSC is stable and there are various
> places where Linux might spot when TSC is unstable. c1e_idle is one
> such place. But it's wrong to mark TSC unstable for all AMD CPUs in
> this function as newer CPU families have TSC's that are P- and C-state
> invariant.

i agree with the purpose of the patch (as it flags the first really sane
TSC implementation on x86!!!) - but it would be nice to indicate this in
a different CPU feature bit other than X86_FEATURE_CONSTANT_TSC, to
reduce confusion. Perhaps introduce a virtual CPU feature bit for that?

Ingo


\
 
 \ /
  Last update: 2008-09-20 08:17    [W:0.063 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site