Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH 02/18] lirc serial port receiver/transmitter device driver | Date | Tue, 16 Sep 2008 00:08:43 -0400 |
| |
On Monday 15 September 2008 14:20:31 Jarod Wilson wrote: > On Sunday 14 September 2008 23:55:38 Jarod Wilson wrote: > > On Saturday 13 September 2008 04:41:33 Stefan Bauer wrote: > > > On Saturday 13 September 2008 02:26, Janne Grunau wrote: > > > > I hope I haven't broken anything with my lirc_dev changes. I doubt > > > > I'll have a change to test it before monday. > > > > > > Unfortunately, you did. Commit ea74897 (port lirc to dynamic device > > > numbers) broke things. [...] > So I've done a bit of work to fix up a few drivers so they properly check > to see that lirc_register_driver() actually succeeded, and then > accidentally stumbled onto the fix for the failure when merging some > coverity-inspired patches from Erik Hovland. lirc_dev.c's lirc_cdev_add() > function had an inverted kmalloc failure check. With that fixed, lirc_i2c > appears to be behaving for me now, although I can't actually check to be > 100% certain until I get home tonight. [...] > Fixes are in the git tree now for anyone else who wants to or is willing to > test. Will verify myself tonight w/lirc_i2c and lirc_mceusb2 at a minimum.
Current git tree works for receiving IR signals via lirc_serial (tested by Janne) and via lirc_mceusb2 (tested by me). Something is still slightly haywire with lirc_i2c though. It registers fine, but IR signals simply aren't making it to lircd. Probably unrelated to the dynamic device num changes, looking into it.
-- Jarod Wilson jarod@redhat.com
| |