lkml.org 
[lkml]   [2008]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] x86: track memtype for RAM in page struct

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> > it should be defined in include/asm-x86/page.h though, not in
> > page-flags.h - other architectures are using this flag for other
> > purposes.
>
> No, other shared-use flags are all defined in page-flags.h:
>
> enum pageflags {
> [...]
> __NR_PAGEFLAGS,
>
> /* Filesystems */
> PG_checked = PG_owner_priv_1,
>
> /* XEN */
> PG_pinned = PG_owner_priv_1,
> PG_savepinned = PG_dirty,
>
> /* SLOB */
> PG_slob_page = PG_active,
> PG_slob_free = PG_private,
>
> /* SLUB */
> PG_slub_frozen = PG_active,
> PG_slub_debug = PG_error,
> };
>
>
> We could #ifdef CONFIG_X86 just to make it clear we're talking about a
> specific X86 usage. But page-flags.h does seem to have become the
> central authority on all struct page flags usage.

well, in case of the PG_arch_* flags, they are all defined in
architecture files:

./include/asm-parisc/pgtable.h:#define PG_dcache_dirty PG_arch_1
./include/asm-mips/cacheflush.h:#define PG_dcache_dirty PG_arch_1
./arch/sparc64/mm/init.c:#define PG_dcache_dirty PG_arch_1
./arch/sh/include/cpu-sh4/cpu/cacheflush.h:#define PG_mapped PG_arch_1
./arch/sh/include/cpu-sh3/cpu/cacheflush.h:#define PG_mapped PG_arch_1
./arch/arm/include/asm/cacheflush.h:#define PG_dcache_dirty PG_arch_1

they are explicitly reserved for per architecture details.

Ingo


\
 
 \ /
  Last update: 2008-09-14 16:25    [W:0.059 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site